[PATCH] D156101: [AMDGPU] Introduce real and keep fake True16 instructions.
Ivan Kosarev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 24 11:24:52 PDT 2023
kosarev added a comment.
> Do we really need `UseTrue16BitInsts`? Can't we control this by enabling/disabling `HasTrue16BitInsts`, like Matt said on D156100 <https://reviews.llvm.org/D156100>?
We already have instructions and patterns that depend on `HasTrue16BitInsts`, so making it false by default would break existing GFX11 tests. `UseTrue16BitInsts` is for instructions and patterns that use real True16 instructions, so making it true by default would also break existing tests because the most of the True16 functionality is still missing. The plan is that these two flags should eventually become the same thing once the transition is done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156101/new/
https://reviews.llvm.org/D156101
More information about the llvm-commits
mailing list