[PATCH] D156100: [AMDGPU] Have a command-line flag to enable true True16 codegen.

Ivan Kosarev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 24 11:01:02 PDT 2023


kosarev added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp:174
+bool AMDGPUSubtarget::useTrue16BitInsts() const {
+  return hasTrue16BitInsts() && EnableTrue16Codegen;
+}
----------------
arsenm wrote:
> arsenm wrote:
> > Can implement this by just clearing the hasTrue16BitInsts feature in the constructor 
> Actually just using -mattr=-true16-whatever should work just as well. Do we really need a dedicated flag?
Done. `HasTrue16BitInsts` should stay raised for the existing tests to pass.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156100/new/

https://reviews.llvm.org/D156100



More information about the llvm-commits mailing list