[PATCH] D156095: [Bazel] Introduce `//compiler-rt:profile`

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: utils/bazel/llvm-project-overlay/compiler-rt/BUILD.bazel:16
+        "COMPILER_RT_HAS_ATOMICS=1",
+        "COMPILER_RT_HAS_FCNTL_LCK=1",
+        "COMPILER_RT_HAS_UNAME=1",
----------------
Windows doesn't define COMPILER_RT_HAS_FCNTL_LCK or COMPILER_RT_HAS_UNAME


================
Comment at: utils/bazel/llvm-project-overlay/compiler-rt/BUILD.bazel:24
+    srcs = glob([
+        "lib/profile/*.c",
+        "lib/profile/*.h",
----------------
We need `lib/profile/*.cpp` for `InstrProfilingRuntime.cpp`


================
Comment at: utils/bazel/llvm-project-overlay/compiler-rt/BUILD.bazel:37
+        "-Wno-pedantic",
+        "-Wno-strict-prototypes",
+    ],
----------------
Are the two -Wno- needed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156095/new/

https://reviews.llvm.org/D156095