[PATCH] D156139: AMDGPU: Fix counting debug instructions in execz skip threshold

[Matt Arsenault via Phabricator via llvm-commits]

arsenm created this revision.
arsenm added reviewers: AMDGPU, cdevadas.
Herald added subscribers: foad, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

https://reviews.llvm.org/D156139

Files:
  llvm/lib/Target/AMDGPU/SIPreEmitPeephole.cpp
  llvm/test/CodeGen/AMDGPU/insert-skips-ignored-insts.mir


Index: llvm/test/CodeGen/AMDGPU/insert-skips-ignored-insts.mir
===================================================================
--- llvm/test/CodeGen/AMDGPU/insert-skips-ignored-insts.mir
+++ llvm/test/CodeGen/AMDGPU/insert-skips-ignored-insts.mir
@@ -2,7 +2,6 @@
 
 ---
 
-# FIXME: RemoveShortExecBranches should not count dbg_value instructions.
 # CHECK-LABEL: name: no_count_dbg_value
 # CHECK: $vgpr1 = V_MOV_B32_e32 7, implicit $exec
 # CHECK-NOT: S_CBRANCH_EXECZ
@@ -18,6 +17,11 @@
     successors: %bb.2
     $vgpr0 = V_MOV_B32_e32 0, implicit $exec
     DBG_VALUE
+    DBG_VALUE
+    DBG_VALUE
+    DBG_VALUE
+    DBG_VALUE
+    DBG_VALUE
 
   bb.2:
     $vgpr0 = V_MOV_B32_e32 1, implicit $exec
Index: llvm/lib/Target/AMDGPU/SIPreEmitPeephole.cpp
===================================================================
--- llvm/lib/Target/AMDGPU/SIPreEmitPeephole.cpp
+++ llvm/lib/Target/AMDGPU/SIPreEmitPeephole.cpp
@@ -320,6 +320,9 @@
       if (MI.isConditionalBranch())
         return true;
 
+      if (MI.isMetaInstruction())
+        continue;
+
       if (TII->hasUnwantedEffectsWhenEXECEmpty(MI))
         return true;
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156139.543593.patch
Type: text/x-patch
Size: 1140 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230724/6a8002fd/attachment.bin>