[PATCH] D156136: [BPF] Clean up SelLowering

Alexei Starovoitov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 24 09:23:00 PDT 2023


ast requested changes to this revision.
ast added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/Target/BPF/BPFISelLowering.cpp:84
     if (VT == MVT::i32) {
-      if (STI.getHasAlu32())
+      if (STI.getHasAlu32()) {
         continue;
----------------
Here and elsewhere.
Did you miss Eduard's comment:
- LLVM Coding Standards actually require brace-less if statements (link <https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements>)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156136/new/

https://reviews.llvm.org/D156136



More information about the llvm-commits mailing list