[PATCH] D156136: [BPF] Clean up SelLowering
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 24 08:55:57 PDT 2023
arsenm added inline comments.
================
Comment at: llvm/lib/Target/BPF/BPFISelLowering.cpp:41
+static void unsupported(const SDLoc &DL, SelectionDAG &DAG, const Twine &Msg,
+ std::optional<SDValue> Val = std::nullopt) {
std::string Str;
----------------
Don't see the point of using optional with SDValue, it already acts like optional on its own
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156136/new/
https://reviews.llvm.org/D156136
More information about the llvm-commits
mailing list