[PATCH] D153260: [RISCV][MC] Implement mapping symbols

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 24 08:55:40 PDT 2023


MaskRay added inline comments.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVELFStreamer.cpp:153
+  Symbol->setBinding(ELF::STB_LOCAL);
+  Symbol->setExternal(false);
+}
----------------
ELF uses symbol bindings and doesn't need `setExternal`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153260/new/

https://reviews.llvm.org/D153260



More information about the llvm-commits mailing list