[PATCH] D156048: [RISCV] Remove unused check prefixes for tests. NFC
Alex Bradbury via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 24 08:35:11 PDT 2023
asb added a comment.
I'm not overly opposed to this having landed, but I'll point out the flip-side of removing these (currently) unsued prefixes is that if future codegen or test changes make use of them, we won't automatically get the benefit of deduplicated checks (in the case of shared prefixes being removed) or will have to go and manually add back a new check prefix (in the case of common prefixes no longer being sufficient due to test output diverging).
This patch is fine, and it's not a huge deal either way, but for the record my current view is I wouldn't be in favour of ripping out all future unused prefixes as soon as they appear.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156048/new/
https://reviews.llvm.org/D156048
More information about the llvm-commits
mailing list