[PATCH] D156134: [AggressiveInstCombine][Docs] Update pass documentation

Maksim Kita via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 24 08:22:08 PDT 2023


kitaisreal created this revision.
kitaisreal added a reviewer: nikic.
kitaisreal added projects: All, LLVM.
Herald added a subscriber: StephenFan.
kitaisreal requested review of this revision.
Herald added a subscriber: llvm-commits.

Updated AggressiveInstCombine pass documentation because now AggressiveInstCombine can modify CFG.
Introduced in D154725 <https://reviews.llvm.org/D154725>.


https://reviews.llvm.org/D156134

Files:
  llvm/docs/Passes.rst


Index: llvm/docs/Passes.rst
===================================================================
--- llvm/docs/Passes.rst
+++ llvm/docs/Passes.rst
@@ -632,14 +632,13 @@
 --------------------------------------------------------
 
 Combine expression patterns to form expressions with fewer, simple instructions.
-This pass does not modify the CFG.
 
 For example, this pass reduce width of expressions post-dominated by TruncInst
 into smaller width when applicable.
 
-It differs from instcombine pass in that it contains pattern optimization that
-requires higher complexity than the O(1), thus, it should run fewer times than
-instcombine pass.
+It differs from instcombine pass in that it can modify CFG and contains pattern
+optimization that requires higher complexity than the O(1), thus, it should run fewer
+times than instcombine pass.
 
 ``-internalize``: Internalize Global Symbols
 --------------------------------------------


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156134.543566.patch
Type: text/x-patch
Size: 938 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230724/97067d45/attachment.bin>


More information about the llvm-commits mailing list