[PATCH] D156084: [RISCV] Update Zvk shorthand extension to 1.0.0-rc1

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

RISCVFeatures.td does feature implication for `llc -mattr=` which does not use RISCVISAInfo.cpp. It could also be used by frontends other than clang that might not use RISCVISAInfo.cpp either. Those frontends might just expose something like llc's `-mattr` interface instead of having target specific logic.

There is no equivalent of `CombineIntoExts` for RISCVFeatures.td. The only use for CombineIntoExts right now is so the frontend will set the preprocessor define for the shorthand extension.

The duplication is unfortunate. Other targets also have some similar duplication.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156084/new/

https://reviews.llvm.org/D156084