[PATCH] D143602: Allow 32-bit pointers to be written in 64-bit slots

David M. Lloyd via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 24 07:10:27 PDT 2023


dmlloyd added a comment.

In D143602#4481817 <https://reviews.llvm.org/D143602#4481817>, @efriedma wrote:

> We have the following options here:
>
> 1. Leave it as, i.e. a backend error
> 2. Commit this as-is, i.e. depending on the target, it might work, but it could also either crash in the assembler or generate an invalid relocation.
> 3. Teach the assembler to emit padding for .quad.
> 4. Emit explicit padding in the AsmPrinter
>
> (2) seems like the worst of these options.

As the original author, I agree; when I wrote this I had wrongly assumed that all assemblers already supported this. I wouldn't mind if (3) or (4) were done but this would likely be beyond my experience with C++.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143602/new/

https://reviews.llvm.org/D143602



More information about the llvm-commits mailing list