[PATCH] D155957: [PPC][AIX] Fix toc-data peephole bug and some related cleanup.

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 24 06:52:55 PDT 2023


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:7735
         // is insufficient for the instruction encoding.
         if (Alignment < 4 && (RequiresMod4Offset || (Offset % 4) != 0)) {
           LLVM_DEBUG(dbgs() << "Rejected this candidate for alignment.\n\n");
----------------
Can we add a FIXME to verify and better document the reason why `Offset` needs to be a multiple of 4 when the alignment is less than 4? It is //not// about the encoding of the instruction: the value of `Offset` comes directly from the original load/store instruction on the path that reaches this check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155957/new/

https://reviews.llvm.org/D155957



More information about the llvm-commits mailing list