[PATCH] D152706: [AMDGPU] Use SSAUpdater in PromoteAlloca

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp:367
+    LoadInst *Dummy =
+        Builder.CreateLoad(VectorTy, UndefValue::get(Builder.getPtrTy()),
+                           "promotealloca.dummyload");
----------------
Use poison for the filler


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp:449
+      unsigned NumCopied = Length->getZExtValue() / ElementSize;
+      MemTransferInfo *TI = &TransferInfo[cast<MemTransferInst>(Inst)];
+      unsigned SrcBegin = TI->SrcIndex->getZExtValue();
----------------
You already have the cast<MemTransferInst> as MTI


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp:479
+    llvm_unreachable("Unsupported call when promoting alloca to vector");
+    break;
+  }
----------------
Dead break


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152706/new/

https://reviews.llvm.org/D152706