[PATCH] D156077: [AMDGPU] Perform basic folds on llvm.amdgcn.wave.reduce.umin/umax.

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstCombineIntrinsic.cpp:1139
   }
+  case Intrinsic::amdgcn_wave_reduce_umin:
+  case Intrinsic::amdgcn_wave_reduce_umax: {
----------------
This should go in `lib/Analysis/ConstantFolding.cpp` instead.


================
Comment at: llvm/test/Transforms/InstCombine/AMDGPU/amdgcn-intrinsics.ll:6197
 }
+
+; --------------------------------------------------------------------
----------------
Tests can go in `test/Transforms/InstSimplify/ConstProp/AMDGPU/`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156077/new/

https://reviews.llvm.org/D156077