[PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 24 03:40:06 PDT 2023


DavidSpickett added a comment.

What I understand is that `MCInstrAnalysis` defaults to using `MCInstrDesc`, however not all targets have `MCInstrAnalysis` at all. So we have this awkwardness here with the two pointers, which is fine.

Sounds good to me, I am just wondering about the changes over in llvm.



================
Comment at: llvm/include/llvm/MC/MCInstrAnalysis.h:80
+  }
+
   /// Returns true if at least one of the register writes performed by
----------------
Does this have test coverage already?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156086/new/

https://reviews.llvm.org/D156086



More information about the llvm-commits mailing list