[PATCH] D155623: [AArch64][NFC] Expand coverage of ReplaceWithVeclib testing using SLEEF vector library

mgabka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 24 03:23:30 PDT 2023


mgabka accepted this revision.
mgabka added a comment.
This revision is now accepted and ready to land.

Thanks for updating the patch, it LGTM.
I realised one more thing, the "fast" flag attached to the calls in the tests is not needed.
The replace-with-veclib pass does not check for it and and performs the transformation always when the mappings exist.
However in this pass there is a chunk of code ensuring that the fast math flags are preserved, so I think we can keep it in your tests as it is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155623/new/

https://reviews.llvm.org/D155623



More information about the llvm-commits mailing list