[PATCH] D149440: [yaml2obj] Add support for load config section data.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with two nits and MaskRay's comment addressed.



================
Comment at: llvm/lib/ObjectYAML/COFFYAML.cpp:559
+void mapLoadConfigMember(IO &IO, T &LoadConfig, const char *Name, M &Member) {
+  // Map only members that mach a specified size.
+  if (reinterpret_cast<char *>(&Member) -
----------------
jhenderson wrote:
> 
Ping this comment.


================
Comment at: llvm/test/tools/yaml2obj/COFF/load-config.yaml:237
+
+## Try to specify load config field that barely fits specified size.
+# RUN: yaml2obj --docnum=5 %s -o %t
----------------
Nit


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149440/new/

https://reviews.llvm.org/D149440