[PATCH] D155829: [LoongArch] Add LSX intrinsic support

[wanglei via Phabricator via llvm-commits]

wangleiat added inline comments.


================
Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:821
+  case Intrinsic::loongarch_lsx_vldi:
+    return checkIntrinsicImmArg<13>(Op, 1, DAG);
   }
----------------
SixWeining wrote:
> `simm13` is used in instruction definition (`LoongArchLSXInstrInfo.td`) while `uimm13` is used here. For consistency, it's better to use `simm13` (binutils also uses `simm13`).
Thank you, I will make the modification.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155829/new/

https://reviews.llvm.org/D155829