[PATCH] D153394: [AArch64][GlobalISel] Legalize <2 x s8> and <4 x s8> for G_BUILD_VECTOR
Allen zhong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jul 23 19:55:13 PDT 2023
Allen marked 3 inline comments as done.
Allen added inline comments.
================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h:944
+ /// Ensure the vector size is at least as wide as Ty by promoting the element.
+ LegalizeRuleSet &promoteVectorEltsToVectorMinSize(unsigned TypeIdx,
----------------
tschuett wrote:
> Nice! s/Ty/VectorSize/ .
Done, thanks
================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h:945
+ /// Ensure the vector size is at least as wide as Ty by promoting the element.
+ LegalizeRuleSet &promoteVectorEltsToVectorMinSize(unsigned TypeIdx,
+ unsigned VectorSize) {
----------------
aemerson wrote:
> Sorry, the name I suggested didn't fit with the rest of the naming scheme. I think `widenVectorEltsToVectorMinSize` is better.
Done, thanks
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153394/new/
https://reviews.llvm.org/D153394
More information about the llvm-commits
mailing list