[PATCH] D149440: [yaml2obj] Add support for load config section data.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 23 16:45:07 PDT 2023


MaskRay added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/COFF/load-config.yaml:10
+# ALL:   Size: 0x150
+# ALL:   TimeDateStamp: 1970-01-01 00:00:01 (0x1)
+# ALL:   MajorVersion: 0x2
----------------
I think we generally add `-NEXT`. When something goes off, `FileCheck` will give a better error. This does mean some maintenance overhead when adding a new field, but in general the advantage outweighs the downside.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149440/new/

https://reviews.llvm.org/D149440



More information about the llvm-commits mailing list