[PATCH] D98591: [CodeGen] Add extension points for TargetPassConfig::addMachinePasses

[Raoul Gough via Phabricator via llvm-commits]

drti added a comment.

Hi @arsenm I've rebased this so it builds against the current HEAD and addressed a couple of inline comments. I don't have commit rights myself, but if you're happy with the current state could you please merge it for me or let me know what the next step is otherwise?

Regards,
@drti



================
Comment at: llvm/include/llvm/CodeGen/TargetPassConfig.h:100
+  /// Callback function type for added extensions to a target.
+  using ExtensionFn = std::function<void(TargetPassConfig &)>;
+
----------------
arsenm wrote:
> Can this be function_ref?
I don't think it can in general because we need to store a list of these and the function_ref docs say "This class does not own the callable, so it is not in general safe to store a function_ref"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98591/new/

https://reviews.llvm.org/D98591