[PATCH] D156013: [BOLT] Fix jump table issue for split functions
Maksim Panchenko via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jul 23 08:37:38 PDT 2023
maksfb added a comment.
In D156013#4524579 <https://reviews.llvm.org/D156013#4524579>, @Amir wrote:
> Thanks. I hope it won't break our jump table detection in unexpected ways.
> As a suggestion to minimize fallout – we can restrict this new treatment to fragment starts only (ie. to *.cold functions only)
In `postProcessJumpTables()` we are not making decisions on what entries belong to the table. The population of the table is happening in `BinaryContext`.
The code that I'm changing is supposed to convert addresses to labels, but was skipping the corner case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156013/new/
https://reviews.llvm.org/D156013
More information about the llvm-commits
mailing list