[PATCH] D155857: [clang] fix nonnull warnings during build
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jul 22 18:00:51 PDT 2023
MaskRay added a comment.
In D155857#4525421 <https://reviews.llvm.org/D155857#4525421>, @fzakaria wrote:
> Address feedback from maskray@
>
> - imperative comment
> - switch to CMAKE_GNU_COMPILER_ID for variable
Does `append_if(CMAKE_GNU_COMPILER_ID "-Wno-nonnull" CMAKE_CXX_FLAGS)` work? `build.ninja` with a GCC doesn't have `-Wno-nonnull`...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155857/new/
https://reviews.llvm.org/D155857
More information about the llvm-commits
mailing list