[PATCH] D155379: [PowerPC] Reorder setMaxAtomicSizeInBitsSupported(). NFC

Brad Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 22 15:06:02 PDT 2023


brad added a comment.

In D155379#4503636 <https://reviews.llvm.org/D155379#4503636>, @MaskRay wrote:

> `shouldInlineQuadwordAtomics` contains a `Subtarget.isPPC64()` check, so this is NFC for both PPC32 and PPC64.

Yes, I would expect `shouldInlineQuadwordAtomics` to check for the appropriate environment.

> I wonder whether PPC32 may make `shouldInlineQuadwordAtomics` true in the future.

If that were the case I would expect `shouldInlineQuadwordAtomics` to check what is appropriate.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155379/new/

https://reviews.llvm.org/D155379



More information about the llvm-commits mailing list