[PATCH] D155732: [MC][COFF][AArch64] Avoid incorrect IMAGE_REL_ARM64_BRANCH26 relocations.

Hiroshi Yamauchi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 22 12:21:39 PDT 2023


hjyamauchi added a comment.

>> Can you clarify? Does it mean that we need to check `A.isInSection() && Layout.getSymbolOffset(A) < getSectionAddressSize(&A.getSection())` before we create a new symbol at where symbol A is? What should happen if that's not the case?
>
> Something like that, yes.  If it fails, we need to print an error, because we don't have any way to encode it.  At least, I don't think we have a way to encode it?  Not sure off the top of my head what offsets the linker would tolerate.

Done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155732/new/

https://reviews.llvm.org/D155732



More information about the llvm-commits mailing list