[PATCH] D155732: [MC][COFF][AArch64] Avoid incorrect IMAGE_REL_ARM64_BRANCH26 relocations.

Hiroshi Yamauchi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 22 12:16:59 PDT 2023


hjyamauchi added a comment.

In D155732#4521023 <https://reviews.llvm.org/D155732#4521023>, @hjyamauchi wrote:

>> There's a bunch of code for A.isTemporary() a few lines earlier; would it make sense to integrate with that? This is sort of similar to what we do with OffsetSymbols, except the maximum offset is zero.
>
> That may make sense as long as it's okay to check if the relocation type is `fixup_aarch64_pcrel_branch26` or `fixup_aarch64_pcrel_call26` before the `getRelocType()` call.

Done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155732/new/

https://reviews.llvm.org/D155732



More information about the llvm-commits mailing list