[PATCH] D155958: [NFC][ValueTracking]: Remove redundant computeKnownBits call for LoadInst in isKnownNonZero

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 22 01:08:01 PDT 2023


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:2547
     if (const auto *Call = dyn_cast<CallBase>(V)) {
       if (Call->isReturnNonNull())
         return true;
----------------
0xdc03 wrote:
> For that matter, I guess this could also be moved into the call instruction case?
Yes, it would make sense to move all the handling here (apart from Argument).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155958/new/

https://reviews.llvm.org/D155958



More information about the llvm-commits mailing list