[PATCH] D155781: [Support] Change StringMap hash function from xxHash64 to xxh3_64bits

[Erik Desjardins via Phabricator via llvm-commits]

erikdesjardins added a comment.

FYI, I ran this against the Rust compiler performance test suite and it didn't make a noticeable difference compared to the initial switch from DJB -> xxhash. (Which makes sense--DJB is so slow that it's hard to make an improvement that's anywhere close to that.)
It does seem to improve an artificial benchmark with very large constant strings by ~3% locally.

It of course still makes sense to do this, even if only to remove the old xxh64.

LGTM with the noted issues resolved.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155781/new/

https://reviews.llvm.org/D155781