[PATCH] D155857: [clang] fix nonnull warnings during build

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 21 20:03:54 PDT 2023


MaskRay added inline comments.


================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:773
 
+  # Disabling this GCC warning as it is emitting a lot of false positives
+  append_if(CMAKE_COMPILER_IS_GNUCXX "-Wno-nonnull" CMAKE_CXX_FLAGS)
----------------
Use an imperative sentence, i.e. `Disable ... ` and append a full stop.

`CMAKE_COMPILER_IS_GNUCXX` is deprecated . Use `CMAKE_<LANG>_COMPILER_ID`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155857/new/

https://reviews.llvm.org/D155857



More information about the llvm-commits mailing list