[PATCH] D155440: ValueTracking: Make computeKnownFPClass respect UseInstrInfo

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 21 15:51:19 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/unittests/Analysis/ValueTrackingTest.cpp:2010
+
+  // Still looks at nofpclass attribute
+  {
----------------
jcranmer-intel wrote:
> Why is `nofpclass` being looked at for UseInstrInfo = false? It doesn't make much sense for `nnan` and `nofpclass(nan)` to be treated differently...
I don't really know what UseInstrInfo is supposed to mean, but this matched the previous behavior. The parameter is undocumented and based on SimplifyQuery it means "don't use flags" for an uncertain definition of flags.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155440/new/

https://reviews.llvm.org/D155440



More information about the llvm-commits mailing list