[PATCH] D155989: [LLD][ELF] Warn on invalid local symbols

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D155989#4523745 <https://reviews.llvm.org/D155989#4523745>, @thevinster wrote:

>> I wonder whether you can consider binary patching the broken shared objects. I have done similar things for my employer (for symbol versioning, not for this STB_LOCAL instance) as well..
>> If binary patching doesn't look great, use --noinhibit-exec.
>
> Patching the binary is something we're probably going to try and pursue, but I wanted to get your thoughts first whether you feel strongly against switching this back to a warning. Using `--noinhibit-exec` relaxes other errors as well and would prefer not to do that to avoid more broken shared objects from creeping. So far, it's just this specific message that I've seen so far.

`errorOrWarn` for this instance seems to be better, for (a) the reason I stated in a previous comment, and (b) to match the `errorOrWarn` binding check `ObjFile<EDLFT>::postParse` (though we may want to remove that one to remove code from a hot patch)...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155989/new/

https://reviews.llvm.org/D155989