[PATCH] D155993: [llvm-debuginfod] Switch to xxh3_64bits

[Fangrui Song via Phabricator via llvm-commits]

MaskRay created this revision.
MaskRay added reviewers: gulfem, mysterymath.
Herald added a subscriber: hiraditya.
Herald added a project: All.
MaskRay requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Many sources show that xxh3 is much better than xxh64. This particular
instance may or may not have noticeable difference, but this change
moves us toward removing xxHash64.

This change will invalid cache and I haven't fixed the tests.
I just want to post the patch first to seek for opinions:)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D155993

Files:
  llvm/lib/Debuginfod/Debuginfod.cpp


Index: llvm/lib/Debuginfod/Debuginfod.cpp
===================================================================
--- llvm/lib/Debuginfod/Debuginfod.cpp
+++ llvm/lib/Debuginfod/Debuginfod.cpp
@@ -47,7 +47,7 @@
 
 using llvm::object::BuildIDRef;
 
-static std::string uniqueKey(llvm::StringRef S) { return utostr(xxHash64(S)); }
+static std::string uniqueKey(llvm::StringRef S) { return utostr(xxh3_64bits(S)); }
 
 // Returns a binary BuildID as a normalized hex string.
 // Uses lowercase for compatibility with common debuginfod servers.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155993.543056.patch
Type: text/x-patch
Size: 536 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230721/967db8d5/attachment.bin>