[PATCH] D155989: [LLD][ELF] Warn on invalid local symbols

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

This is shared object parsing and the performance is less important. If it is important, it may be attempting to remove this error check to have less code in the hot path and just assume that all non-local symbols are not STB_LOCAL. Before we do that, we probably want this to be an error for sufficiently long time.

I wonder whether you can consider binary patching the broken shared objects. I have done similar things for my employer (for symbol versioning, not for this ) as well..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155989/new/

https://reviews.llvm.org/D155989