[PATCH] D155986: [clang][AMDGPU]: Don't use byval for struct arguments in function ABI

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 21 13:13:00 PDT 2023


arsenm added a comment.

In D155986#4523635 <https://reviews.llvm.org/D155986#4523635>, @jdoerfert wrote:

> I would have assumed it makes more sense to have an IR pass that changes the ABI of functions with local linkage. The problem with this is that other languages might still emit byval, etc.

I think this would be good as an alternative optimization, but this wouldn't change the C ABI to avoid byval. I think we don't want byval for whenever we have an object linkable ABI


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155986/new/

https://reviews.llvm.org/D155986



More information about the llvm-commits mailing list