[PATCH] D155544: [AIX][TLS] Add -maix-small-local-exec-tls option.

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:4095
+  HelpText<"Produce a faster access sequence for local-exec TLS variables "
+           "where the offset from the thread pointer value is encoded as an "
+           "immediate operand (AIX 64-bit only). "
----------------
Same comment: use "TLS base".


================
Comment at: clang/test/Driver/aix-small-local-exec-tls.c:2
+// RUN: %clang -target powerpc64-unknown-aix -S -emit-llvm %s -o - | FileCheck %s
+// RUN: %clang -target powerpc-unknown-aix -S -emit-llvm %s -o - | FileCheck %s
+// RUN: %clang -target powerpc64le-unknown-linux-gnu -S -emit-llvm %s -o - | FileCheck %s
----------------
It was agreed in offline discussion that 32-bit AIX should generate a message about the option because the general semantics are meaningful in that context but there is no implementation.


================
Comment at: llvm/test/CodeGen/PowerPC/check-aix-small-local-exec-tls-opt.ll:6
+; RUN:   FileCheck %s --check-prefix=CHECK-NOT-SUPPORTED
+
+define dso_local signext i32 @f() {
----------------
Same comment re: 32-bit AIX.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155544/new/

https://reviews.llvm.org/D155544