[PATCH] D154102: Headers for basic blocks in control flow dot graphs

Artur Pilipenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 21 10:07:08 PDT 2023


apilipenko added a comment.

I think a better structure would be:

- Don't emit the block name in HandleBasicBlock. Instead of printing the BB, just iterate through the instructions and print them 1 by 1.
- Unconditionally prepend the block name in CompleteNodeLabelString.



================
Comment at: llvm/include/llvm/Analysis/CFGPrinter.h:138
 }
-
 template <typename BasicBlockT>
----------------
Please, avoid unrelated whiteline changes


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154102/new/

https://reviews.llvm.org/D154102



More information about the llvm-commits mailing list