[PATCH] D155789: [Support] Implement LLVM_ENABLE_REVERSE_ITERATION for StringMap

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 21 08:37:44 PDT 2023


MaskRay added a comment.

In D155789#4521423 <https://reviews.llvm.org/D155789#4521423>, @jhenderson wrote:

> https://llvm.org/docs/CMake.html documents "LLVM_REVERSE_ITERATION". Is this an error in the doc (it should be "LLVM_ENABLE_REVERSE_ITERATION")?

It seems that both `-DLLVM_REVERSE_ITERATION=1` and `-DLLVM_ENABLE_REVERSE_ITERATION=1` are supported... I think this may not be intentional, and we probably should converge on one spelling for the CMake variable.

llvm-zorg has one instance of `LLVM_REVERSE_ITERATION`, so perhaps `LLVM_REVERSE_ITERATION` is preferred...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155789/new/

https://reviews.llvm.org/D155789



More information about the llvm-commits mailing list