[PATCH] D155958: [NFC][ValueTracking]: Remove redundant computeKnownBits call for LoadInst in isKnownNonZero
Dhruv Chawla via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 21 08:11:35 PDT 2023
0xdc03 added inline comments.
================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:2549
if (Q.IIQ.getMetadata(LI, LLVMContext::MD_nonnull))
return true;
----------------
nikic wrote:
> It would be good to move this check into the load switch case.
Done, though I do wonder why this was originally put here. I guess it is a relic from the merge of `isKnownNonNull` and `isKnownNonZero` that was never updated.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155958/new/
https://reviews.llvm.org/D155958
More information about the llvm-commits
mailing list