[PATCH] D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation

[Paul Osmialowski via Phabricator via llvm-commits]

pawosm01 marked 3 inline comments as done.
pawosm01 added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:2702
+  bool AnyAdds = false;
+  SmallVector<std::pair<BinaryOperator *, std::pair<Value *, int>>> Changes;
+  for (BinaryOperator *Op = nullptr, *OpNext = nullptr,
----------------
nikic wrote:
> I think you just reinvented `Use`? That's how you reference a specific operand of an instruction.
Ok, I've changed it to make use of `Use`, I hope you'll like it.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152281/new/

https://reviews.llvm.org/D152281