[lld] 29112a9 - Mark this test as unsupported on Windows systems

Aaron Ballman via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 21 05:11:10 PDT 2023


Author: Aaron Ballman
Date: 2023-07-21T08:10:52-04:00
New Revision: 29112a994694baee070a2021e00f772f1913d214

URL: https://github.com/llvm/llvm-project/commit/29112a994694baee070a2021e00f772f1913d214
DIFF: https://github.com/llvm/llvm-project/commit/29112a994694baee070a2021e00f772f1913d214.diff

LOG: Mark this test as unsupported on Windows systems

There is a strange issue happening with command line processing though. The
command line argument
   --export-dynamic-symbol 'f*'
does not have the single quotes stripped on some Windows targets (but not
all). This causes the glob matching to fail, which means the test fails on
some Windows bots and passes on others.

This is expected to be a temporary measure to get bots back to green. I've not
found a commit that has caused a behavioral change that could be reverted
instead, so this could be an issue with lit or test machine configuration.

Added: 
    

Modified: 
    lld/test/ELF/export-dynamic-symbol.s

Removed: 
    


################################################################################
diff  --git a/lld/test/ELF/export-dynamic-symbol.s b/lld/test/ELF/export-dynamic-symbol.s
index a6c292bfce2878..3a00f07a420cf0 100644
--- a/lld/test/ELF/export-dynamic-symbol.s
+++ b/lld/test/ELF/export-dynamic-symbol.s
@@ -1,5 +1,15 @@
 # REQUIRES: x86
 
+# FIXME: this should be supported on Windows as well. There is a strange issue
+# happening with command line processing though. The command line argument
+#   --export-dynamic-symbol 'f*'
+# does not have the single quotes stripped on some Windows targets (but not
+# all). This causes the glob matching to fail, which means the test fails on
+# some Windows bots and passes on others. However, there's no clear indication
+# as to what's changed to cause this behavior. Marking the test as unsupported
+# so that we have time to investigate the issue without losing postcommit CI.
+# UNSUPPORTED: system-windows
+
 # RUN: llvm-mc -filetype=obj -triple=x86_64 %s -o %t.o
 
 ## For an executable, --export-dynamic-symbol exports a symbol if it is non-local and defined.


        


More information about the llvm-commits mailing list