[PATCH] D155917: [LoongArch] Add definition for LVZ/LBT instructions

wanglei via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 21 01:21:59 PDT 2023


wangleiat marked 2 inline comments as done.
wangleiat added inline comments.


================
Comment at: llvm/lib/Target/LoongArch/LoongArchLBTInstrInfo.td:53-56
+def LDL_W : LOAD_2RI12<0x2e000000>;
+def LDR_W : LOAD_2RI12<0x2e400000>;
+def STL_W : STORE_2RI12<0x2f000000>;
+def STR_W : STORE_2RI12<0x2f400000>;
----------------
xen0n wrote:
> These should be marked mayLoad/Store accordingly.
> These should be marked mayLoad/Store accordingly.

Thank you for your comments. These attributes has already been set in LOAD_2RI12/STORE_2RI12. 
To serve as a reminder, I added some comments.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155917/new/

https://reviews.llvm.org/D155917



More information about the llvm-commits mailing list