[PATCH] D154899: [SystemZ] Allow symbols in immediate asm operands

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 21 00:34:02 PDT 2023


uweigand accepted this revision.
uweigand added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: llvm/test/MC/SystemZ/fixups.s:8
+# RUN: llvm-mc -triple s390x-unknown-unknown -mcpu=z13 -filetype=obj %s | \
+# RUN: llvm-objdump -d - | FileCheck %s -check-prefix=CHECK-DIS
+
----------------
iii wrote:
> uweigand wrote:
> > Would it make sense to add `CHECK-DIS` lines to the existing tests as well?
> For the new tests it's important, because it allows us to check the resolved immediate value. The existing tests depend relocations, so it's going to be only zeroes anyway.
OK, makes sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154899/new/

https://reviews.llvm.org/D154899



More information about the llvm-commits mailing list