[PATCH] D155732: [MC][COFF][AArch64] Avoid incorrect IMAGE_REL_ARM64_BRANCH26 relocations.

Hiroshi Yamauchi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 20 18:35:53 PDT 2023


hjyamauchi added a comment.

> You can't create symbols at arbitrary offsets from the start of a section; you need to check that the symbol actually points somewhere within the section.

Can you clarify? Does it mean that we need to check `A.isInSection() && Layout.getSymbolOffset(A) < getSectionAddressSize(&A.getSection())` before we create a new symbol at where symbol A is? What should happen if that's not the case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155732/new/

https://reviews.llvm.org/D155732



More information about the llvm-commits mailing list