[PATCH] D155732: [MC][COFF][AArch64] Avoid incorrect IMAGE_REL_ARM64_BRANCH26 relocations.

[Hiroshi Yamauchi via Phabricator via llvm-commits]

hjyamauchi added a comment.

> We should teach adjustFixupValue() in AArch64AsmBackend.cpp to print an error if an unresolved branch with an offset gets there somehow.

If you mean like the following, that would unintentionally trigger when we drop the relocation in the newly-added code (in the `if (MCSec == &A.getSection())` case) because `IsResolved` is false.

  case AArch64::fixup_aarch64_pcrel_branch26:
  case AArch64::fixup_aarch64_pcrel_call26:
    if (TheTriple.isOSBinFormatCOFF() && !IsResolved && SignedValue != 0) {
      // MSVC link.exe and lld do not support this relocation type with a non-zero offset
      Ctx.reportError(Fixup.getLoc(), "fixup value not supported by the linkers");
    }




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155732/new/

https://reviews.llvm.org/D155732