[PATCH] D155894: BPF: fail reports a fatal error

[Alessandro Decina via Phabricator via llvm-commits]

alessandrod added inline comments.


================
Comment at: llvm/lib/Target/BPF/BPFISelLowering.cpp:51
   OS.flush();
-  DAG.getContext()->diagnose(
-      DiagnosticInfoUnsupported(MF.getFunction(), Str, DL.getDebugLoc()));
+  report_fatal_error(Twine(Str));
 }
----------------
If you do this, you also need to update the callers which are still doing work after calling fail, but fail now never returns.

Also in LowerCall, the fail call in the ExternalSymbolSDNode case should be removed. That is a legitimate condition when compiling rust code where the builtin is provided by another crate so it shouldn't abort.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155894/new/

https://reviews.llvm.org/D155894