[PATCH] D155874: [llvm] Exit early if inputs to comparator are equal

[David Berard via Phabricator via llvm-commits]

davidberard98 added a comment.

@ABataev @ayermolo could you let me know if you still want a test for this, and if so do you have suggestions on where/how to add it?

context on why I'm not sure where to add a test - as far as I can tell, BoUpSLP internals are not exposed outside of SLPVectorizer.cpp. Meanwhile, I don't think I can reproduce the error "organically" - i.e. I don't think we ever encounter the case where V1 == V2 except with this CheckedCompare code path linked above. So, I could refactor some of this code to expose PHICompare somewhere where it can be unit tested, but I figured I'd ask first whether this is a good idea or whether you have other suggestions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155874/new/

https://reviews.llvm.org/D155874