[PATCH] D155535: [WebAssembly][Objcopy] Write output section headers identically to inputs

[Derek Schuff via Phabricator via llvm-commits]

dschuff added inline comments.


================
Comment at: llvm/include/llvm/Object/Wasm.h:113
   std::vector<wasm::WasmRelocation> Relocations; // Relocations for this section
+  std::optional<uint8_t> HeaderSecSizeEncodingLen;
 };
----------------
jhenderson wrote:
> aheejin wrote:
> > One-liner comment on what this is (in line with other members above) would be nice
> FWIW, I think the comments for the other variables are redundant for the most part (e.g. the ones for type, offset and relocations provide no additional info beyond what the variable name provides).
I agree that some of those comments don't add much use, and removed those; I left the others in, and added one for the new field.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155535/new/

https://reviews.llvm.org/D155535