[PATCH] D155900: [TTI][NFCI] Introduce two new target transform hooks

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfoImpl.h:822
+    if (!ParamAS.hasAttributes() && !ArgAS.hasAttributes())
+      return true;
+    if (ParamAS.getByValType() != ArgAS.getByValType())
----------------
arsenm wrote:
> arsenm wrote:
> > Should also check inreg matches
> Also careful of arbitrary string attributes?
Maybe skip address space pairs that aren't isNoopAddrSpaceCast


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155900/new/

https://reviews.llvm.org/D155900