[PATCH] D155900: [TTI][NFCI] Introduce two new target transform hooks

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfoImpl.h:821-832
+    if (!ParamAS.hasAttributes() && !ArgAS.hasAttributes())
+      return true;
+    if (ParamAS.getByValType() != ArgAS.getByValType())
+      return false;
+    if (ParamAS.getByRefType() != ArgAS.getByRefType())
+      return false;
+    if (ParamAS.getInAllocaType() != ArgAS.getInAllocaType())
----------------
Move this into Attributes somewhere to check for ABI compatible attributes?


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfoImpl.h:822
+    if (!ParamAS.hasAttributes() && !ArgAS.hasAttributes())
+      return true;
+    if (ParamAS.getByValType() != ArgAS.getByValType())
----------------
Should also check inreg matches


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155900/new/

https://reviews.llvm.org/D155900