[PATCH] D155896: [Target][MC} Cleaning up AssemblerDialect / InstructionPrinterSyntaxVariant

[Christoph Stiller via Phabricator via llvm-commits]

rainerzufalldererste created this revision.
rainerzufalldererste added reviewers: uweigand, grosbach, t.p.northover, pengfei.
Herald added subscribers: luke, mattd, gchakrabarti, pmatos, asb, asavonic, foad, frasercrmck, kerbowa, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, jrtc27, gbedwell, niosHD, sabuasal, simoncook, johnrusso, rbar, fedor.sergeev, kbarton, hiraditya, jgravelle-google, arichardson, sbc100, jvesely, nemanjai, sdardis, dylanmckay, jyknight, dschuff, arsenm.
Herald added a reviewer: andreadb.
Herald added a project: All.
rainerzufalldererste requested review of this revision.
Herald added subscribers: llvm-commits, wangpc, MaskRay, aheejin, jholewinski.
Herald added a project: LLVM.

I'm fairly new to LLVM, so I'm not entirely sure if this is remotely something that'll ever get accepted, however, I've found the seemingly random integers representing various different syntax variants to be not particularly well documented and found the option to simply add a comment to be not particularly future proof. I apologize in advance if this change isn't appreciated as I'm not familiar with how such things are usually being improved, so I won't be upset if this is simply going to be rejected.

I've had another branch that included InlineAsm variants as well, but the rabbit hole was already a lot deeper than I originally anticipated, so I've left those changes out, unless otherwise requested.

I've only tagged the code-owners of projects that received meaningful changes, if this isn't correct, please let me know and I'll add everyone else as well.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D155896

Files:
  llvm/include/llvm/MC/MCAsmInfo.h
  llvm/include/llvm/MC/MCParser/MCAsmParser.h
  llvm/include/llvm/MC/TargetRegistry.h
  llvm/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp
  llvm/lib/MC/MCDisassembler/Disassembler.cpp
  llvm/lib/MC/MCParser/AsmParser.cpp
  llvm/lib/MC/MCParser/MasmParser.cpp
  llvm/lib/Object/ModuleSymbolTable.cpp
  llvm/lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp
  llvm/lib/Target/AArch64/MCTargetDesc/AArch64MCTargetDesc.cpp
  llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCTargetDesc.cpp
  llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp
  llvm/lib/Target/ARM/MCTargetDesc/ARMMCTargetDesc.cpp
  llvm/lib/Target/AVR/MCTargetDesc/AVRMCTargetDesc.cpp
  llvm/lib/Target/BPF/MCTargetDesc/BPFMCTargetDesc.cpp
  llvm/lib/Target/Hexagon/MCTargetDesc/HexagonMCTargetDesc.cpp
  llvm/lib/Target/Lanai/MCTargetDesc/LanaiMCTargetDesc.cpp
  llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchMCTargetDesc.cpp
  llvm/lib/Target/MSP430/MCTargetDesc/MSP430MCTargetDesc.cpp
  llvm/lib/Target/Mips/MCTargetDesc/MipsMCTargetDesc.cpp
  llvm/lib/Target/NVPTX/MCTargetDesc/NVPTXMCTargetDesc.cpp
  llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCAsmInfo.cpp
  llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCTargetDesc.cpp
  llvm/lib/Target/RISCV/MCTargetDesc/RISCVMCTargetDesc.cpp
  llvm/lib/Target/Sparc/MCTargetDesc/SparcMCTargetDesc.cpp
  llvm/lib/Target/SystemZ/AsmParser/SystemZAsmParser.cpp
  llvm/lib/Target/SystemZ/MCTargetDesc/SystemZInstPrinter.cpp
  llvm/lib/Target/SystemZ/MCTargetDesc/SystemZMCAsmInfo.cpp
  llvm/lib/Target/SystemZ/MCTargetDesc/SystemZMCAsmInfo.h
  llvm/lib/Target/SystemZ/MCTargetDesc/SystemZMCTargetDesc.cpp
  llvm/lib/Target/SystemZ/SystemZAsmPrinter.cpp
  llvm/lib/Target/VE/MCTargetDesc/VEMCTargetDesc.cpp
  llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.cpp
  llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
  llvm/lib/Target/X86/MCTargetDesc/X86MCAsmInfo.cpp
  llvm/lib/Target/X86/MCTargetDesc/X86MCTargetDesc.cpp
  llvm/lib/Target/XCore/MCTargetDesc/XCoreMCTargetDesc.cpp
  llvm/tools/llvm-exegesis/lib/DisassemblerHelper.cpp
  llvm/tools/llvm-mc/llvm-mc.cpp
  llvm/tools/llvm-mca/CodeRegionGenerator.h
  llvm/tools/llvm-mca/llvm-mca.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155896.542694.patch
Type: text/x-patch
Size: 41256 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230720/01abfd6f/attachment-0001.bin>